Added support for multiple languages#3
Open
BartoszRojek wants to merge 8 commits intoaryanpingle:mainfrom
Open
Added support for multiple languages#3BartoszRojek wants to merge 8 commits intoaryanpingle:mainfrom
BartoszRojek wants to merge 8 commits intoaryanpingle:mainfrom
Conversation
✅ Deploy Preview for apollo-archive ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Author
|
@aryanpingle Hey man, it's been over three months. I know you’re probably busy, but if that’s the case, could you nominate someone you trust to review the PR or just go with the "Fire & Forget" approach? Let me know if you want it tweaked further! 😊 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
The Horizon series is also one of the best I’ve ever had the chance to experience, and I’ve experienced quite a lot. This site strikes me as a so-called “Passion Project,” I like it very much. The fact that it’s rarely visited doesn’t matter – it’s a gem, one of a kind. :)
Back to the updates... I started painstakingly translating the files but realized it was pointless. Since translating the site into any language requires a lot of work anyway, a much better solution would be to add multilingual support to the site and minimize the effort needed to create additional translations.
So, I did what I thought was right:
Additionally:
Lastly, the Audio part will come later, I just didn't want to postpone the current changes.
Let me know what you think.