Suggest new rule #5
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduces a new ESLint rule,
no-complex-conditionals, to improve code readability by limiting the number of logical operators (&&,||,??) within conditional statements (e.g.,if,while,for,do-while, ternary).The rule aims to prevent overly complex conditions that are difficult to parse and maintain, encouraging developers to extract intricate logic into separate variables or functions. It is configurable via
maxOperators, with a default limit of 2.Fixes # (issue)
Type of change
How Has This Been Tested?
A new test file,
tests/no-complex-conditionals.test.ts, was created following a TDD approach. It includes comprehensive valid and invalid cases to verify the rule's behavior with default and custommaxOperatorsconfigurations across different conditional statement types.To reproduce, run:
pnpm test tests/no-complex-conditionals.test.tsChecklist: