Example of test failure output; occurs 1/10 times or so#12
Open
Example of test failure output; occurs 1/10 times or so#12
Conversation
Collaborator
|
Oh, that's great. I was encountering such errors in the much larger sims produced by simupop and was despairing ever finding what the problem was in such large ARGs. I suspect the error is in msprime, but we'll see. I'll debug; but if you need this short-term you can fall back to earlier versions. |
Collaborator
|
Oh, right. The problem is that msprime determines the number of samples automatically as the smallest-numbered internal node. I was not ensuring that this was the case. This will change soon in msprime, so I am hacking something in. |
Collaborator
|
I fixed that; there remain some issues at least with .simplify(): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@petrelharp two things:
msprimethat your latest changes depend on to current master 2150a014094f026e9e19c01809d2df67b3e57190 See git submodule for details