Skip to content

Update setup.ps1 #1345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ashmind merged 2 commits into from
Nov 18, 2024
Merged

Update setup.ps1 #1345

ashmind merged 2 commits into from
Nov 18, 2024

Conversation

@WeihanLi
Copy link
Contributor

@WeihanLi WeihanLi commented Sep 18, 2024

update net7.0 to net8.0 for the $binPath, fixes error

Line |
 101 |      $acl = Get-Acl $binPath
     |             ~~~~~~~~~~~~~~~~
     | Cannot find path './bin/Debug/net7.0' because it does not exist.

@WeihanLi
Update setup.ps1
2e18aa0 
update `net7.0` to `net8.0` for the $binPath
@ashmind
Copy link
Owner

ashmind commented Nov 18, 2024

Thanks for submitting -- I just updated to 9.0 so I'll have to update that, but I am happy to merge this first either way.

@ashmind ashmind enabled auto-merge (squash) November 18, 2024 21:39
@ashmind ashmind disabled auto-merge November 18, 2024 21:40
@ashmind ashmind enabled auto-merge November 18, 2024 21:40
@ashmind ashmind merged commit 13f374e into ashmind:main Nov 18, 2024
9 checks passed
ashmind added a commit that referenced this pull request Nov 18, 2024
@ashmind
[gh-1345] Update setup.ps1 to .NET 9
d7d0ee1
@WeihanLi WeihanLi deleted the patch-1 branch November 18, 2024 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ashmind ashmind ashmind approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@WeihanLi @ashmind