build system integration#1
Open
christianparpart wants to merge 2 commits intoasmuth-archive:masterfrom
christianparpart:master
Open
build system integration#1christianparpart wants to merge 2 commits intoasmuth-archive:masterfrom christianparpart:master
christianparpart wants to merge 2 commits intoasmuth-archive:masterfrom
christianparpart:master
Conversation
Please review the contents of the CMakeLists.txt files; they are pretty easy to understand and to extend. I chose cmake as libsmatrix (as a embedded external project) is very easy to integrate into dawanda_recommender project. I considered using automake, too, but cmake was just easier to get running. Feel free to counter this with an automake-solution, that easily integrates into dawanda_recommender, too. ;-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Paul, please consider this for inclusion.
the realized build system is pretty straight forward, its text files (I wrote) easy to read and easy to extend;
Although, I wouldn't care less if we wouldn't need to integrate libsmatrix as a bundled external project into dawanda_recommender/tools/libsmatrix, which is now very easy.
Cheers,
Christian.