Introduce autorolestargetname to allow for custom target IAM roles#15
Open
nmasur wants to merge 1 commit intoassetnote:masterfrom
Open
Introduce autorolestargetname to allow for custom target IAM roles#15nmasur wants to merge 1 commit intoassetnote:masterfrom
nmasur wants to merge 1 commit intoassetnote:masterfrom
Conversation
Instead of hardcoding GhostBusterTargetAccountRole, allow for an optional role name. This is helpful for Control Tower users, since all accounts include the aws-controltower-ReadOnlyExecutionRole.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of hardcoding
GhostBusterTargetAccountRole, allow for an optional role name. This is helpful for Control Tower users, since all accounts include theaws-controltower-ReadOnlyExecutionRolerole for the Audit account.Fixes #14 .
I haven't spent much time on this pull request. I just came up with something and introduced it as an example.