-
Notifications
You must be signed in to change notification settings - Fork 1.2k
configure.ac: use AC_PATH_TOOL for nm #1608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Checklist Complete
|
Workflow PRCheck completed successfully |
jcolp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Asterisk project commits a generated configure script to make it easy for users. You will need to regenerate using bootstrap.sh and include the regenerated configure script in this change.
|
The PR check also needs to be fulfilled and branches specified. |
|
Running |
|
Squash it all down to one commit, it's fine. |
|
Workflow PRCheck completed successfully |
|
Workflow PRCheck completed successfully |
|
cherry-pick-to: 22 |
|
@nwf This PR has been sitting for a while. If you want it merged, you need to fix the commit message and PR description so they match. |
`nm` might, especially in cross-compilation scenarios, be available but prefixed with the target triple. So: use `AC_PATH_TOOL` rather than `AC_PATH_PROG` to find it. (See https://www.gnu.org/software/autoconf/manual/autoconf-2.68/html_node/Generic-Programs.html .) Found and proposed fix tested by cross-compiling Asterisk using Nixpkgs on x86_64 targeting aarch64. :)
|
Workflow PRCPCheck failed |
gtjoseph
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR doesn't cherry-pick cleanly to the 23 branch although it does cherry-pick cleanly to 22 and 20. You're going to need to do the following...
Edit the cherry-pick-to comment in this PR and remove the cherry-pick-to: 23 line.
In your development repo...
$ git checkout 23
$ git cherry-pick 2228239998f06185fec21
# It's going to fail but that's OK.
$ git add configure
# configure will be invalid but that's OK.
$ git cherry-pick --continue
$ ./bootstrap.sh
# configure will now be regenerated.
$ git commit -a --amend --no-edit
# Create a new PR just for 23.
$ gh pr create --fill --base 23
Now add a `cherry-pick-to: none` comment to the new PR.|
Workflow PRCPCheck failed |
|
Successfully merged to branch master and cherry-picked to ["22","20"] |
nmmight, especially in cross-compilation scenarios, be available but prefixed with the target triple. So: useAC_PATH_TOOLrather thanAC_PATH_PROGto find it. (See https://www.gnu.org/software/autoconf/manual/autoconf-2.68/html_node/Generic-Programs.html .)Found and proposed fix tested by cross-compiling Asterisk using Nixpkgs on x86_64 targeting aarch64. :)