Skip to content

Conversation

@nwf
Copy link
Contributor

@nwf nwf commented Nov 25, 2025

nm might, especially in cross-compilation scenarios, be available but prefixed with the target triple. So: use AC_PATH_TOOL rather than AC_PATH_PROG to find it. (See https://www.gnu.org/software/autoconf/manual/autoconf-2.68/html_node/Generic-Programs.html .)

Found and proposed fix tested by cross-compiling Asterisk using Nixpkgs on x86_64 targeting aarch64. :)

@sangoma-oss-cla
Copy link

sangoma-oss-cla bot commented Nov 25, 2025

CLA assistant check
All committers have signed the CLA.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Checklist Complete

@github-actions github-actions bot added the has-pr-checklist A PR Checklist is present on the PR label Nov 25, 2025
@github-actions
Copy link

Workflow PRCheck completed successfully

Copy link
Member

@jcolp jcolp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Asterisk project commits a generated configure script to make it easy for users. You will need to regenerate using bootstrap.sh and include the regenerated configure script in this change.

@jcolp
Copy link
Member

jcolp commented Nov 27, 2025

The PR check also needs to be fulfilled and branches specified.

@nwf
Copy link
Contributor Author

nwf commented Nov 27, 2025

Running ./bootstrap.sh on 5d15a42 makes changes to ./configure. I've pulled those out to a commit prior to my change, and then ran ./bootstrap.sh again after AC_PATH_TOOL-ization of nm as a 3rd commit. Please feel free to squash appropriately, or tell me that I have done something wrong because the first of those should be empty.

@jcolp
Copy link
Member

jcolp commented Nov 27, 2025

Squash it all down to one commit, it's fine.

@github-actions
Copy link

Workflow PRCheck completed successfully

@github-actions
Copy link

Workflow PRCheck completed successfully

nwf pushed a commit to nwf/nixpkgs that referenced this pull request Dec 3, 2025
@gtjoseph
Copy link
Member

gtjoseph commented Dec 29, 2025

cherry-pick-to: 22
cherry-pick-to: 20

@gtjoseph
Copy link
Member

@nwf This PR has been sitting for a while. If you want it merged, you need to fix the commit message and PR description so they match.

`nm` might, especially in cross-compilation scenarios, be available but prefixed with the target triple. So: use `AC_PATH_TOOL` rather than `AC_PATH_PROG` to find it. (See https://www.gnu.org/software/autoconf/manual/autoconf-2.68/html_node/Generic-Programs.html .)

Found and proposed fix tested by cross-compiling Asterisk using Nixpkgs on x86_64 targeting aarch64. :)
@gtjoseph gtjoseph added cherry-pick-test Trigger dry run of cherry-picks and removed pre-merge-checks-failed labels Dec 29, 2025
@github-actions github-actions bot added cherry-pick-testing-in-progress Cherry-Pick tests in progress cherry-pick-checks-failed Cherry-Pick checks failed and removed cherry-pick-test Trigger dry run of cherry-picks cherry-pick-testing-in-progress Cherry-Pick tests in progress labels Dec 29, 2025
@github-actions
Copy link

Workflow PRCPCheck failed
Setup: cherryPick.sh: Unable to cherry-pick commit 'configure.ac: use AC_PATH_TOOL for nm' to branch 23

Copy link
Member

@gtjoseph gtjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR doesn't cherry-pick cleanly to the 23 branch although it does cherry-pick cleanly to 22 and 20. You're going to need to do the following...

Edit the cherry-pick-to comment in this PR and remove the cherry-pick-to: 23 line.

In your development repo...

$ git checkout 23
$ git cherry-pick 2228239998f06185fec21
# It's going to fail but that's OK.
$ git add configure
# configure will be invalid but that's OK.
$ git cherry-pick --continue
$ ./bootstrap.sh
# configure will now be regenerated.
$ git commit -a --amend --no-edit
# Create a new PR just for 23.
$ gh pr create --fill --base 23

Now add a `cherry-pick-to: none` comment to the new PR.

@gtjoseph gtjoseph added the cherry-pick-test Trigger dry run of cherry-picks label Dec 30, 2025
@github-actions github-actions bot added cherry-pick-testing-in-progress Cherry-Pick tests in progress and removed cherry-pick-test Trigger dry run of cherry-picks cherry-pick-checks-failed Cherry-Pick checks failed labels Dec 30, 2025
@github-actions github-actions bot added cherry-pick-checks-failed Cherry-Pick checks failed and removed cherry-pick-testing-in-progress Cherry-Pick tests in progress labels Dec 30, 2025
@github-actions
Copy link

Workflow PRCPCheck failed
20-pjs1: FAILED TEST: channels/pjsip/headers/non_anonymous_from_basic_call

@github-actions github-actions bot merged commit 0b2c064 into asterisk:master Dec 30, 2025
75 of 78 checks passed
@github-actions
Copy link

Successfully merged to branch master and cherry-picked to ["22","20"]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants