Skip to content

Comments

Notifications (consoleui) and host fix#7

Closed
ReactorCoreDev wants to merge 12 commits intoastra1dev:mainfrom
ReactorCoreDev:main
Closed

Notifications (consoleui) and host fix#7
ReactorCoreDev wants to merge 12 commits intoastra1dev:mainfrom
ReactorCoreDev:main

Conversation

@ReactorCoreDev
Copy link

the thing astra asked for

@astra1dev
Copy link
Owner

blud does not know how branches work

@astra1dev astra1dev closed this Nov 18, 2025
@ReactorCoreDev
Copy link
Author

I apologize as I am new to using github.

@astra1dev
Copy link
Owner

astra1dev commented Nov 18, 2025

thats fine, however I recommend that you learn the basics first before you open a PR. Also this code was originally written by someone else (See PR #4)

@ReactorCoreDev
Copy link
Author

Yeah, I know I forgot to give credit in the description because I rushed this and did the fixes u wanted in PR #4. I will repost this after I learn the basics

@astra1dev
Copy link
Owner

astra1dev commented Nov 18, 2025

I didn't "want" any fixes, I simply asked the original author if they still want to get it merged or not.
Taking someone else's code from an existing unmerged PR and adding it to your own PR is not a very nice thing to do. (Except if you talked to them and they said its ok)

@ReactorCoreDev
Copy link
Author

My bad

@ReactorCoreDev
Copy link
Author

Also, set the default tree to 'astralum' instead of 'main'.

@ReactorCoreDev
Copy link
Author

I didn't "want" any fixes, I simply asked the original author if they still want to get it merged or not. Taking someone else's code from an existing unmerged PR and adding it to your own PR is not a very nice thing to do. (Except if you talked to them and they said its ok)

I meant:
Remove unnecessary changes like whitespace removals
Fix conflicts
Use the existing ConsoleUI instead of creating a Notifications UI

@astra1dev
Copy link
Owner

I think I'm just going to edit the original PR myself, resolve the merge conflicts, and merge it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants