Serve assets from issuer account#159
Merged
charlie-wasp merged 12 commits intomasterfrom May 20, 2019
Merged
Conversation
f78561a to
da38731
Compare
Contributor
Author
|
Also here is the new |
da38731 to
4105eb0
Compare
nebolsin
approved these changes
May 20, 2019
Member
nebolsin
left a comment
There was a problem hiding this comment.
Reviewed 12 of 17 files at r1, 18 of 18 files at r2.
Reviewable status:complete! all files reviewed, all discussions resolved
9a2a094 to
01801fd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What we've got here:
More technical notes:
AssetWithInfofrom the schema, we have one typeAssetnowquery { assets }response because it breaks alphanumeric sorting in pagination. It happens because we use"native"as an id for XLM, which serves as pagination token too, so native XLM won't be between other assets with codes, starting on "X". And it seems not very useful to have it there anyway. If the user would like to obtain some statistics about lumens, they can do it viaquery { asset(id: "native") }Assetclass fromstellar-sdkonly for parsing XDR, and use our newAssetclass everywhere else, but I didn't refactor that for now, because it looks like a big deal. Definitely, something to do laterThis change is