Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Conversation

@abetomo
Copy link
Contributor

@abetomo abetomo commented Apr 28, 2020

Requirements for Contributing a Bug Fix

Identify the Bug

Node.js14 issues the following warning, so update the 'nan'.

../node_modules/nan/nan_typedarray_contents.h:34:43: warning: 'GetContents' is deprecated: Use GetBackingStore. See
      http://crbug.com/v8/9908. [-Wdeprecated-declarations]
      data   = static_cast<char*>(buffer->GetContents().Data()) + byte_offset;

Description of the Change

I upgraded the 'nam' by running an npm update.

Alternate Designs

Possible Drawbacks

Verification Process

Release Notes

abetomo added 2 commits April 28, 2020 09:20
Node.js14 issues the following warning, so update the 'nan'.

```
../node_modules/nan/nan_typedarray_contents.h:34:43: warning: 'GetContents' is deprecated: Use GetBackingStore. See
      http://crbug.com/v8/9908. [-Wdeprecated-declarations]
      data   = static_cast<char*>(buffer->GetContents().Data()) + byte_offset;
```
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants