Open
Conversation
Collaborator
|
This is the first non-trivial change to the code since the release of the tutorial, which means it's a good test for the CI that I will setup soon. So I'll leave this PR open until that's done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current logic in
wordle_server.cis incorrect. If a misplaced letter keeps appearing more than the number of times it has appeared in the target word, it should not keep showing as yellow.Example 1:
Example 2:
Where
Yis yellow,Gis green, andXis grey.Concerns are:
calculate_statesfunction then pack MRs using thestatesglobalcounts[word[i] - 'a']++is clear enough