Conversation
Contributor
Reviewer's Guide by SourceryThis PR removes Python 3.8 support by updating type hints to use newer Python syntax and modifying CI configuration files. The changes primarily involve updating type annotations to use the Python 3.9+ syntax for generics (e.g., Updated class diagram for type annotationsclassDiagram
class OpenSmileException {
int code
str message
OpenSmileException(int code, str message=None)
}
class Smile {
str|FeatureSet feature_set
str|FeatureLevel feature_level
dict options
int loglevel
str logfile
int sampling_rate
int|Sequence~int~ channels
bool mixdown
bool resample
audinterface.Segment segment
bool keep_nat
int|None num_workers
bool multiprocessing
bool verbose
Smile(str|FeatureSet feature_set, str|FeatureLevel feature_level, dict options=None, int loglevel=2, str logfile=None, int sampling_rate=None, int|Sequence~int~ channels=0, bool mixdown=False, bool resample=False, audinterface.Segment segment=None, bool keep_nat=False, int|None num_workers=1, bool multiprocessing=False, bool verbose=False)
}
class FeatureSetResolver {
str|FeatureSet decode(str value)
str encode(str|FeatureSet value)
}
class FeatureLevelResolver {
str|FeatureLevel decode(str value)
str encode(str|FeatureLevel value)
}
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
|
Contributor
There was a problem hiding this comment.
Hey @hagenw - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove support for Python 3.8.
It also updates the code by stop using
typing.Summary by Sourcery
Remove support for Python 3.8 and update type annotations to use PEP 604 syntax. Update CI workflows to drop Python 3.8 and use Python 3.9, 3.10, and 3.11. Adjust project metadata to reflect the new minimum Python version requirement of 3.9.
Enhancements:
CI: