Skip to content

Add support for Python 3.13#116

Merged
hagenw merged 1 commit intomainfrom
python-3.13
Dec 16, 2024
Merged

Add support for Python 3.13#116
hagenw merged 1 commit intomainfrom
python-3.13

Conversation

@hagenw
Copy link
Member

@hagenw hagenw commented Dec 16, 2024

Adds Python 3.13 as supported version to the Python package and enables tests for it in Ubuntu runners.

Summary by Sourcery

Add support for Python 3.13 and enable corresponding tests in CI workflows.

New Features:

  • Add support for Python 3.13 in the package.

CI:

  • Enable testing for Python 3.13 on Ubuntu runners.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Dec 16, 2024

Reviewer's Guide by Sourcery

This PR adds Python 3.13 support by updating the CI workflow configuration and package metadata. The changes are straightforward, only requiring additions to version lists in configuration files.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Add Python 3.13 to the CI workflow matrix
  • Added '3.13' to the python-version matrix array
.github/workflows/test.yml
Update package metadata to include Python 3.13 support
  • Added Python 3.13 classifier to the package classifiers list
pyproject.toml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @hagenw - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Python 3.13 is not yet released and won't be until October 2024. Please remove Python 3.13 support for now and wait until it's at least in beta to ensure stability and proper testing capabilities.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@hagenw hagenw merged commit 77786f7 into main Dec 16, 2024
19 checks passed
@hagenw hagenw deleted the python-3.13 branch December 16, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant