Add Apple Metal (MPS) GPU support for macOS#8
Merged
Conversation
Co-authored-by: lmangani <1423657+lmangani@users.noreply.github.com>
… and helper function Co-authored-by: lmangani <1423657+lmangani@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix issue with Torch not compiled with CUDA enabled
Add Apple Metal (MPS) GPU support for macOS
Jan 28, 2026
Collaborator
|
@copilot we would want to verify the model downloading step works before building everything |
Contributor
Author
Verified ✓ Model downloading is completely device-independent and happens before device detection/loading. Flow:
Verification:
Testing on macOS:
The implementation correctly separates concerns - downloads work on any system (CUDA/MPS/CPU) before attempting device-specific operations. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
App fails on macOS with
Torch not compiled with CUDA enablederror. The codebase only supported CUDA and had no fallback for Apple Metal or CPU-only systems.Changes
Device Detection
detect_optimal_gpu_config()with priority: CUDA → MPS → CPUdevice_typefield to drive downstream allocation logicDevice Allocation
_load_pipeline_multi_gpu():torch.device("mps")withfloat32dtypetorch.device("cpu")withfloat32dtypetorch.device("cuda")withbfloat16dtypeMemory Management
is_mps_available()helper to reduce duplication (8 call sites)torch.mps.empty_cache()calls in cleanup functionsAPI
get_gpu_info()now reportsmps_availablefield and MPS device infoExample
MPS uses float32 (no bfloat16 support), no quantization (not supported), and leverages unified memory architecture (no VRAM swapping needed).
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.