Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✏️ Changes
Attempt to upgrade extensions-cli to webtask v5. This was tested only with DAE, but can actually work for other extensions as well. Until this is properly tested for other extensions, i don't feel confident merging it into
master.📷 Screenshots
🔗 References
🎯 Testing
Tested with DAE. Both dev mode (npm run serve:dev) and prod mode (npm run build & deploy generated assets to webtask) seem to be working fine.
✅ This change has been tested in a Webtask
✅ This change has unit test coverage
✅ This change has integration test coverage
✅ This change has been tested for performance
🎡 Rollout
Need to properly test it with other extensions, not only DAE.
🔥 Rollback
📄 Procedure