Remove unsafe Swift code from OTP code generation#105
Open
emiliopavia wants to merge 2 commits intoauth0:masterfrom
Open
Remove unsafe Swift code from OTP code generation#105emiliopavia wants to merge 2 commits intoauth0:masterfrom
emiliopavia wants to merge 2 commits intoauth0:masterfrom
Conversation
|
Any update on this? |
|
@Widcket may you take a look? |
Contributor
|
Hi @emiliopavia and @ObidosDev, thanks for raising this. However, I'm not the maintainer of this library –I'll defer to @ionutmanolache-okta. |
|
Any update on this? This is kinda huge problem for now |
|
Updates?) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By submitting a PR to this repository, you agree to the terms within the Auth0 Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.
Description
On iOS 16 we're receiving several exceptions from the
code(counter:)function inOneTimePasswordGenerator. The exception is related to the block called in thewithUnsafeBytesfunction.This PR aims to replace the code without using unsafe pointers (as suggested by Apple in Swift support forums).
References
Testing
The code is already covered by tests.
Checklist