feat: consent details binding message optional#161
Merged
ionutmanolache-okta merged 3 commits intomasterfrom Dec 3, 2025
Merged
feat: consent details binding message optional#161ionutmanolache-okta merged 3 commits intomasterfrom
ionutmanolache-okta merged 3 commits intomasterfrom
Conversation
Contributor
There was a problem hiding this comment.
is this needed?
Contributor
Author
There was a problem hiding this comment.
XCode keeps updating this file, so I figured I was better to commit but I'm happy to revert the changes.
Package.resolved
Outdated
Contributor
There was a problem hiding this comment.
is this needed?
Contributor
Author
There was a problem hiding this comment.
No, I guess it's not. It's not ignored either and it seems to be generated by XCode, shall we include it .gitignore? Removed in 4533e12
| describe("Decodable") { | ||
| it("should load from Json decoder") { | ||
| let jsonData = "{\"audience\":\"my_audience\",\"scope\":[\"openid\",\"my_scope\"],\"binding_message\":\"my_binding_message\"}"; | ||
| let jsonData = "{\"audience\":\"my_audience\",\"scope\":[\"openid\",\"my_scope\"]}"; |
Contributor
There was a problem hiding this comment.
nit: maybe change the test description too? "should load from Json decoder without binding_message"
ionutmanolache-okta
approved these changes
Dec 1, 2025
Artelas
approved these changes
Dec 2, 2025
ionutmanolache-okta
pushed a commit
that referenced
this pull request
Dec 4, 2025
* feat: consent details binding message optional * test: clarify test description * fix: remove unnecessary package.resolved file (cherry picked from commit c4b2fa0)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By submitting a PR to this repository, you agree to the terms within the Auth0 Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.
Description
Introduces support for rich consent transactions with no binding message included in the consent details.
Testing
Checklist