Skip to content

chore: fix flake in parser tests #2897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tstirrat15 merged 1 commit into from
Feb 12, 2026
Merged

chore: fix flake in parser tests #2897

tstirrat15 merged 1 commit into from
Feb 12, 2026
+1 −1

Conversation

@tstirrat15
Copy link
Contributor

@tstirrat15 tstirrat15 commented Feb 12, 2026

Description

See https://github.com/authzed/spicedb/actions/runs/21960769188/job/63437367755?pr=2892

Changes

  • Sort the flags so that it's deterministic

Testing

Review.

@tstirrat15 tstirrat15 marked this pull request as ready for review February 12, 2026 19:35
@tstirrat15 tstirrat15 requested a review from a team as a code owner February 12, 2026 19:35
@tstirrat15 tstirrat15 enabled auto-merge (squash) February 12, 2026 19:36
josephschorr
josephschorr approved these changes Feb 12, 2026
View reviewed changes
Copy link
Member

@josephschorr josephschorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

barakmich
barakmich approved these changes Feb 12, 2026
View reviewed changes
Copy link
Contributor

@barakmich barakmich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@codecov
Copy link

codecov bot commented Feb 12, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.59%. Comparing base (c33320f) to head (57d8552).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2897      +/-   ##
==========================================
- Coverage   74.62%   74.59%   -0.02%     
==========================================
  Files         484      484              
  Lines       58538    58538              
==========================================
- Hits        43678    43661      -17     
- Misses      11796    11812      +16     
- Partials     3064     3065       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tstirrat15 tstirrat15 merged commit 0b407f0 into main Feb 12, 2026
76 of 78 checks passed
@tstirrat15 tstirrat15 deleted the fix-composable-schema-parser-flake branch February 12, 2026 20:09
@github-actions github-actions bot locked and limited conversation to collaborators Feb 12, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@barakmich barakmich barakmich approved these changes

@josephschorr josephschorr josephschorr approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tstirrat15 @barakmich @josephschorr