Fix mobile scrolling issues #107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rizontal overflow - Remove redundant overflow-y-auto from ListView (was nested inside main's scroll) - Remove deprecated -webkit-overflow-scrolling: touch inline style and CSS rule - Add overflow-x-hidden to main content, Panel content, and ItemDetailsModal - Add overscroll-y-contain and touch-action on main for native-feeling scroll - Add flex layout to #root for proper height propagation - Simplify overscroll-behavior CSS to just contain child scroll containers Fixes: weird scrolling feel on mobile and horizontal scroll in Edit Item panel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the weird scrolling behavior on mobile and horizontal scroll in the Edit Item panel.
Changes
overflow-y-autoinside main's scroll context, causing competing scroll behaviors-webkit-overflow-scrolling: touch(both inline and CSS rule) — deprecated and can cause jankoverflow-x-hiddento Panel content area and ItemDetailsModal contenttouch-action: pan-y pinch-zoomandoverscroll-y-containon main for smooth native-feeling scrollRoot cause
Nested scroll containers (
body overflow:hidden→#root overflow:hidden→main overflow-y-auto→ListView overflow-y-auto) were fighting each other, making scrolling feel 'off'. The horizontal scroll was from content overflowing the panel width.Build tested: ✅
bun run buildpasses