Skip to content

Conversation

@cnjhb
Copy link
Contributor

@cnjhb cnjhb commented Jan 9, 2026

The timer callback must return SOURCE_CONTINUE or SOURCE_REMOVE. Although these are essentially equivalent to true and false, this approach is more rigorous.

@cnjhb cnjhb changed the title fix(timer): return glib.SOURCE_TINUE fix(timer): return glib.SOURCE_CONTINUE instead true Jan 9, 2026
@codecov
Copy link

codecov bot commented Jan 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.41%. Comparing base (cab3e81) to head (dcf1140).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4046   +/-   ##
=======================================
  Coverage   90.40%   90.41%           
=======================================
  Files         938      938           
  Lines       60250    60251    +1     
  Branches     1139     1139           
=======================================
+ Hits        54472    54478    +6     
+ Misses       5270     5267    -3     
+ Partials      508      506    -2     
Files with missing lines Coverage Δ
lib/gears/timer.lua 95.29% <100.00%> (ø)

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant