Skip to content

Comments

Log debug info in Browser plugin request handler#151

Open
IgorMilavec wants to merge 2 commits intoaws:masterfrom
IgorMilavec:debug
Open

Log debug info in Browser plugin request handler#151
IgorMilavec wants to merge 2 commits intoaws:masterfrom
IgorMilavec:debug

Conversation

@IgorMilavec
Copy link

Description

This PR adds more diagnostic info to the driver's logs to be able to provide some insight into the credentials exchange process.

Motivation and Context

During debugging sessions AWS Support will request a HAR file, which is hard to produce as the browser plugins open the login_url in a new browser window.

Testing

Tested by using BrowserSamlCredentialsProvider from SQL WOrkbench/J.

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed
  • A short description of the change has been added to the CHANGELOG

License

  • By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant