Feature addition: Enable setting the STS Endpoint from the SAML Assertion#57
Open
jmfuchs wants to merge 1 commit intoaws:masterfrom
Open
Feature addition: Enable setting the STS Endpoint from the SAML Assertion#57jmfuchs wants to merge 1 commit intoaws:masterfrom
jmfuchs wants to merge 1 commit intoaws:masterfrom
Conversation
Author
|
Anyone able to take a look at this? |
Contributor
|
Hi Jesse, sorry for the late reply. Your changes looks good but as this affect the authentication, in AWS we have to go through the security review. I will discuss with my manager again, how to speed this up. |
Contributor
|
@jmfuchs Thanks for submitting this PR, we will review this and get back to you as soon as we have an update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added functionality in SamlCredentialsProvider.java to support setting the STS endpoint from a claim (StsEndpointUrl) in the SAML assertion.
Motivation and Context
In a scenario where a regional STS endpoint is having availability issues, this change allows a central administrator to modify the STS endpoint in a single place in the IdP configuration to accelerate the recovery of access to RedShift clusters. The regional endpoint can currently be changed using extended properties, but it requires every redshift user to modify their configuration. This will reduce the overhead on redshift users and accelerate recovery time. The change does allow the redshift user to overwrite the endpoint passed in the SAML assertion using extended properties if desired.
Testing
For testing, I rebuilt the driver with the updated code and manually ran through the following tests to ensure everything functioned as expected:
Types of changes
Checklist
mvn installsucceedsLicense