Sagemaker e2e test #95
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
December 5, 2025 10:43
… into sagemaker-e2e-test
… into sagemaker-e2e-test
… into sagemaker-e2e-test
… into sagemaker-e2e-test
vpaiu
reviewed
Dec 8, 2025
| npx playwright install | ||
| SSO_USERNAME="$SSO_USERNAME" SSO_PASSWORD="$SSO_PASSWORD" DATAZONE_URL="$DATAZONE_URL" SPACE_NAME="$SAGEMAKER_SPACE_NAME" VSCODE_REMOTE_SERVER_PATH="sagemaker" npm run mocha -- --web --headless | ||
|
|
||
| SSO_USERNAME="$SSO_USERNAME" SSO_PASSWORD="$SSO_PASSWORD" DATAZONE_URL="$DATAZONE_URL" SPACE_NAME="$SAGEMAKER_SPACE_NAME" VSCODE_REMOTE_SERVER_PATH="sagemaker" npm run mocha -- --web --headless 2>&1 | tee test_output.log |
Contributor
There was a problem hiding this comment.
For now, I think this fix is good. But we should later look into why npm run mocha doesn't exit with code 1 on tests failing.
A think a fix would be using the actual smoketest npm command (https://github.com/microsoft/vscode/blob/main/package.json#L43). As when I was working on the smoke testing I didn't notice it in the package.json.
Contributor
Author
There was a problem hiding this comment.
Yes, will look into it
Contributor
Author
There was a problem hiding this comment.
smoketest command will not be used as it rebuilds entire vscode src which makes space out of scope
added 4 commits
December 8, 2025 10:20
Contributor
|
Another improvement we can make: I noticed when we construct the DATAZONE_URL we hardcode the region, but we should instead use the AWS_REGION env variable. |
feiyangliu2023
had a problem deploying
to
sagemaker-e2e-tests-workflow-env
GitHub Actions
Failure
vpaiu
reviewed
Dec 8, 2025
|
|
||
| - name: Download sagemaker build artifact | ||
| run: | | ||
| gh run download --name "$COMMIT_SHA-code-editor-sagemaker-server-build" |
Contributor
There was a problem hiding this comment.
This should still have the commit sha
vpaiu
reviewed
Dec 8, 2025
| - name: Fetch source artifact | ||
| run: | | ||
| gh run download --name "$COMMIT_SHA-code-editor-sagemaker-server-src" |
Contributor
There was a problem hiding this comment.
This should still have the commit sha
added 2 commits
December 8, 2025 12:03
feiyangliu2023
had a problem deploying
to
sagemaker-e2e-tests-workflow-env
GitHub Actions
Failure
feiyangliu2023
had a problem deploying
to
sagemaker-e2e-tests-workflow-env
GitHub Actions
Failure
added 3 commits
December 8, 2025 14:02
… into sagemaker-e2e-test
… into sagemaker-e2e-test
feiyangliu2023
had a problem deploying
to
sagemaker-e2e-tests-workflow-env
GitHub Actions
Failure
feiyangliu2023
had a problem deploying
to
sagemaker-e2e-tests-workflow-env
GitHub Actions
Failure
feiyangliu2023
had a problem deploying
to
sagemaker-e2e-tests-workflow-env
GitHub Actions
Failure
feiyangliu2023
had a problem deploying
to
sagemaker-e2e-tests-workflow-env
GitHub Actions
Failure
added 6 commits
December 8, 2025 15:49
… into sagemaker-e2e-test
… into sagemaker-e2e-test
… into sagemaker-e2e-test
… into sagemaker-e2e-test
vpaiu
approved these changes
Dec 8, 2025
feiyangliu2023
added a commit
to feiyangliu2023/code-editorv2
that referenced
this pull request
Dec 10, 2025
Co-authored-by: Feiyang Liu <lfeiyang@amazon.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
D354258334
The workflow was completing successfully even when smoke tests failed because the mocha test runner returns exit code 0 regardless of test results.
Description of Changes
Fixes SageMaker smoke test workflow to properly fail when tests fail.
Capture mocha output and parse it for the "failing" keyword to detect test failures, then explicitly exit with code 1 to fail the workflow.
Testing
Verified with workflow run showing "2 failing" tests now properly fails the CI pipeline.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.