Remove defaults configuration to rely on baked in preferences#64
Open
jahkeup wants to merge 2 commits intoaws:masterfrom
Open
Remove defaults configuration to rely on baked in preferences#64jahkeup wants to merge 2 commits intoaws:masterfrom
jahkeup wants to merge 2 commits intoaws:masterfrom
Conversation
Signed-off-by: Jacob Vallejo <jakeev@amazon.com>
EC2 Mac images bake these values into the image now and existing systems will already have the settings applied even if updated to the new configuration file (assuming they've booted at least once, eg: to run a brew-update or equivalent). There isn't an inherent issue with configuring preferences at boot, however these particular settings for SoftwareUpdate are inconsistently persisting when applying at boot. These preferences are now set during image build time and persisted in the images, so init no longer needs to do the needful. Signed-off-by: Jacob Vallejo <jakeev@amazon.com>
dpakpak
approved these changes
Oct 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
n/a
Description of changes:
This change removes the
defaultsnow set and persisted in image build activities.Also added a cheap check of the
init.tomlthat's committed to validate ahead of packaging.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.