Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1190 +/- ##
==========================================
- Coverage 84.25% 84.24% -0.01%
==========================================
Files 57 57
Lines 5981 5980 -1
==========================================
- Hits 5039 5038 -1
Misses 942 942 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, and/or reason for changes (REQUIRED):
aws_check_sanitizerchecks for the sanitizer flags usingcheck_c_compiler_flag. However, C language might be disabled for C++ projects, which leads to the following error:Description of changes:
Add check for C++ compiler.
Check compiler flags only if corresponding language is enabled.
If both C and C++ compilers are not loaded, no
check_*_compiler_flagfunction will be called and sanitizer won't be enabled. In a way, it's similar to current logic: when C compiler doesn't support a specified sanitizer check, cmake simply doesn't add corresponding compiler flags.CMAKE_CXX_COMPILER_LOADEDandCMAKE_C_COMPILER_LOADEDare available since at least CMake 3.0.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.