Split item filtering into separate source file#75
Merged
Helias merged 8 commits intoazerothcore:rework-1from May 9, 2024
Merged
Split item filtering into separate source file#75Helias merged 8 commits intoazerothcore:rework-1from
Helias merged 8 commits intoazerothcore:rework-1from
Conversation
Helias
approved these changes
Nov 4, 2023
Member
|
thanks for your PR! |
Author
|
Buildfail is actually something from rework branch Also I put the wrong license header, trinitycore one instead of AC |
Author
|
Are you okey with my file naming? The other files all prefix "AuctionHouseBot", but I don't think there is actually a technical reason to do that? |
Author
|
This is still waiting, any update? I would like to make more contributions but its very hard to handle all the conflicts. |
Member
|
merged, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addition onto #57
Merge current Master branch (would be better to do that into rework branch first)
Split the item indexing/filtering out into separate files, and fix the broken conditions introduced in #57
Actual changes in eab81cf
I compared item counts from before(non-broken master branch)/after to confirm they match
With Rogue items disabled (Because I modified the way disabled class items are filtered)
All still matches