Skip to content

[B3-2706] Hide BSMNT header#305

Open
GioLogist wants to merge 1 commit intomainfrom
B3-2706-sdk-css
Open

[B3-2706] Hide BSMNT header#305
GioLogist wants to merge 1 commit intomainfrom
B3-2706-sdk-css

Conversation

@GioLogist
Copy link
Collaborator

@GioLogist GioLogist commented Oct 26, 2025

B3-2706

Description

Update css class w new classname to hide header

Test Plan

  • Locally
  • Unit Tests
  • Manually
  • CI/CD

Screenshots

For BE, include snippets, response payloads and/or curl commands to test endpoints

[FE] Before

image

[FE] After

image

[BE] Snippets/Response/Curl


automerge=false

@GioLogist GioLogist requested a review from a team as a code owner October 26, 2025 20:38
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @GioLogist, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses ticket B3-2706 by implementing a targeted styling change to hide a specific header component within modal interfaces. The update involves modifying a CSS file to apply a display: none property to the designated header, thereby preventing its visibility and streamlining the modal's presentation.

Highlights

  • CSS Styling Update: A new CSS class, .b3-modal .css-1893pav, has been added to the existing display: none !important; rule within packages/sdk/src/styles/index.css. This modification ensures that a specific header element, referred to as the 'BSMNT header', is hidden when rendered inside a modal.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a CSS override to hide a header element by targeting a new generated class name. While this fixes the issue, relying on generated class names is fragile and can lead to future maintenance problems. My review includes a suggestion to add comments to document these brittle selectors, which will help with future debugging.

Comment on lines 345 to 349
.b3-modal .css-1m9ejup,
.b3-modal .css-1cv2836 {
.b3-modal .css-1cv2836,
.b3-modal .css-1893pav {
display: none !important;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Using generated class names like .css-1893pav is a fragile approach because they can change with any third-party library update, breaking this override. This creates technical debt.

To improve maintainability, please add comments explaining what each of these cryptic class names targets. This will be invaluable for future debugging. I've added a suggestion with placeholders for you to fill in.

Suggested change
.b3-modal .css-1m9ejup,
.b3-modal .css-1cv2836 {
.b3-modal .css-1cv2836,
.b3-modal .css-1893pav {
display: none !important;
}
.b3-modal .css-1m9ejup, /* Targets: (please specify) */
.b3-modal .css-1cv2836, /* Targets: (please specify) */
.b3-modal .css-1893pav { /* Targets: (please specify) */
display: none !important;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant