Fix dark theme to inherit from html.dark class

[nnti3n]

Use CSS selector html.dark .b3-root to support next-themes
SDK Should not handle theme since it's too problematic (flashing dark/light on render)

[LINEAR_ISSUE_ID_HERE]

Description

Write a description.

Test Plan

• Locally
• Unit Tests
• Manually
• CI/CD

Screenshots

For BE, include snippets, response payloads and/or curl commands to test endpoints

[FE] Before

[FE] After

[BE] Snippets/Response/Curl

---

automerge=false

[gemini-code-assist]

Summary of Changes

Hello @nnti3n, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the dark theme implementation within the SDK to enhance compatibility with external theme management solutions, such as next-themes. By shifting the responsibility of theme application from the SDK's root component to a global html.dark CSS class, it streamlines theme integration and resolves issues like theme flashing during rendering.

Highlights

• Theme Management Refactor: The SDK's internal theme handling logic, previously managed by the StyleRoot component using a data-theme attribute, has been removed. Theme state is now expected to be managed externally.
• CSS Selector Update: Dark theme styles in index.css now apply when the html element has the dark class (html.dark .b3-root), aligning with common external theme management patterns like next-themes.
• Improved Compatibility: This change enhances compatibility with external theme libraries and addresses potential issues such as 'flashing dark/light on render' by delegating theme control.
• Direct Dark Mode Styling: A specific component, OrderHistory.tsx, has been updated to directly apply a dark mode background class (dark:bg-as-surface-primary) to its ModalHeader.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request refactors the dark theme implementation to rely on an html.dark class instead of a data-theme attribute on the SDK's root element. This is a good change that aligns with modern practices, for example with next-themes, and should resolve the flashing issue mentioned. The changes in StyleRoot.tsx and OrderHistory.tsx are correct. However, the refactoring in the CSS is incomplete. I've left a comment on a missed update in index.css that would lead to broken dark mode styles for modals.

[gemini-code-assist]

While this change correctly updates the main dark theme selector, a related selector for modals on line 293 was missed: .b3-root[data-theme="dark"] .b3-modal. It still uses the old data-theme attribute, which will result in broken dark mode styles for modals.

To fix this, please update it to html.dark .b3-root .b3-modal to be consistent with the new theming approach.