Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
When the checkoutSession prop is provided, fiat orders are created via POST /checkout-sessions instead of POST /orders. The backend creates the order internally, so existing polling and payment UI continue to work unchanged. The redirect URL on completion uses the session's resolved success_url directly (no order ID appended). Components updated: AnySpend, AnySpendCustom, AnySpendCustomExactIn Also updated: OrderDetails redirect logic, useAnyspendFlow hook Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Documents the full checkout sessions integration including component prop usage, hooks API, service methods, and types. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Summary of ChangesHello @aqt-dev, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new "Checkout Sessions" feature to the AnySpend SDK, designed to streamline the payment process for merchants by offering a Stripe-like experience. It enables merchants to easily create payment sessions, redirect users to hosted payment pages, and manage post-payment redirects. The changes encompass new API endpoints, dedicated React hooks for both session creation and polling, and seamless integration into existing AnySpend UI components, significantly simplifying the implementation of fiat payment flows. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a comprehensive checkout sessions feature, similar to Stripe, which is a great addition. The implementation spans across new documentation, hooks, services, and component updates. The code is generally well-structured. My review focuses on improving type safety by removing any types and addressing a couple of potentially unsafe type assertions that could lead to runtime errors. I've also included a minor suggestion to improve the new documentation.
| dstTokenAddress: getDstToken().address, | ||
| srcFiatAmount: srcAmountOnRamp, | ||
| onramp: { | ||
| vendor: vendor as "coinbase" | "stripe-web2" | "none", |
There was a problem hiding this comment.
There's a potentially unsafe type assertion here. The vendor variable can be "stripe", but the type for checkout session creation (useAnyspendCreateCheckoutSessionOrder) does not include "stripe". This could lead to runtime errors if a user selects a payment method that resolves to the "stripe" vendor. Instead of casting, it would be safer to handle this case explicitly, for example by preventing the checkout session flow for unsupported vendors or mapping them to a supported one if applicable.
| dstTokenAddress: dstToken.address, | ||
| srcFiatAmount: onrampAmount, | ||
| onramp: { | ||
| vendor: onramp.vendor as "coinbase" | "stripe-web2" | "none", |
There was a problem hiding this comment.
Similar to another component, there's a risky type assertion here. The onramp.vendor can be "stripe", which is not a supported vendor for checkout sessions. This could cause runtime failures. Please add a check to handle unsupported vendors for the checkout session flow instead of just casting the type.
| | Property | Type | Description | | ||
| |----------|------|-------------| | ||
| | `createSession` | `(params: CreateCheckoutSessionRequest) => void` | Trigger session creation | | ||
| | `createSessionAsync` | `(params: CreateCheckoutSessionRequest) => Promise` | Async version | |
There was a problem hiding this comment.
The return type for createSessionAsync is documented as a generic Promise. For better clarity and type safety in the documentation, it would be beneficial to specify the resolved value's type, which appears to be Promise<CheckoutSession>.
| | `createSessionAsync` | `(params: CreateCheckoutSessionRequest) => Promise` | Async version | | |
| | `createSessionAsync` | `(params: CreateCheckoutSessionRequest) => Promise<CheckoutSession>` | Async version | |
|
|
||
| export type UseAnyspendCreateCheckoutSessionOrderProps = { | ||
| checkoutSession: CheckoutSessionConfig; | ||
| onSuccess?: (data: any) => void; |
There was a problem hiding this comment.
The data parameter in the onSuccess callback is typed as any. To improve type safety and developer experience, it should be explicitly typed as CreateCheckoutSessionResponse. You'll need to import this type from ../../types/checkoutSession.
| onSuccess?: (data: any) => void; | |
| onSuccess?: (data: CreateCheckoutSessionResponse) => void; |
| error, | ||
| } = useMutation({ | ||
| mutationFn: (params: CreateCheckoutSessionRequest) => anyspendService.createCheckoutSession(params), | ||
| onSuccess: data => { |
There was a problem hiding this comment.
The data parameter is implicitly any. For better type safety, please explicitly type it as CreateCheckoutSessionResponse.
| onSuccess: data => { | |
| onSuccess: (data: CreateCheckoutSessionResponse) => { |
1 participant
No description provided.