Open
Conversation
Owner
|
It should work with master branch of ffmpeg4-sys. I just can't release -sys crate because it's version is tied to ffmpeg, which is unfortunate. |
Author
|
Err, just cloning it gives I guess master's travis build is passing because it has been built prior to the rust-ffmpeg4-sys bump? |
bacek
reviewed
Mar 17, 2020
Owner
|
Yes, it is.
…On Wed, Mar 18, 2020 at 8:39 AM Polochon-street ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In .travis.yml
<#6 (comment)>:
> @@ -33,3 +33,4 @@ before_install:
script: |
travis_wait cargo build --verbose --features "build"
I guess cargo build --examples... should be enough? :)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#6 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAFFELHQM7XKYW5H7V7HILRH7UXXANCNFSM4LDRRLYA>
.
--
Regards,
Vasily
|
11fe490 to
cb21a6c
Compare
cb21a6c to
67a0982
Compare
Author
|
@bacek I've updated stuff with your latest changes on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed two things:
I saw rust-ffmpeg4-sys version was bumped, but it's still not working using
4.2.2so just switched the branch to the stable version (it's failing anyways 😄 )More important change: I've removed the alloc() in the context resampling, since swr_convert_frame allocates stuff itself here https://ffmpeg.org/doxygen/trunk/swresample__frame_8c_source.html more precisely, calculating itself the number of frame needed. Also fixed the flush()
Hope it makes sense 😄