Skip to content

Fix a null pointer dereference bug in function parse_msg#248

Open
mugitya03 wants to merge 1 commit intobaidu:masterfrom
mugitya03:NPD-1
Open

Fix a null pointer dereference bug in function parse_msg#248
mugitya03 wants to merge 1 commit intobaidu:masterfrom
mugitya03:NPD-1

Conversation

@mugitya03
Copy link

In function field2json, if repeated = false, the NULL value of json is returned to the caller.

static rapidjson::Value* field2json(const Message *msg, const FieldDescriptor *field,
        rapidjson::Value::AllocatorType& allocator)
{
    ...
    rapidjson::Value* json = NULL;
    if (repeated)
    {
        json = new rapidjson::Value(rapidjson::kArrayType);
    }
    ...
    return json;
}

In caller function parse_msg, the return value of function field2json is dereferenced without any null value check, causing a null pointer dereference bug.

            rapidjson::Value* field_json = field2json(msg, field, allocator);
            root->AddMember(name, *field_json, allocator);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants