Open
Conversation
|
@remorses is your fork compatible with their V2 API? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this?
native-fetchso this package can be used in Cloudflare workers and non Node.js runtimesmodulefolderobject, as object is basically an alias for any, while you intended to refer to a "dict": https://www.typescripttutorial.net/typescript-tutorial/typescript-object-type/BananaErrorfor errors and make the original banana response accessibleWhy?
Makes DX much better, allows you to use this package in Cloudflare workers, Vercel edge, etc
How did you test to ensure no regressions?
Tested on my own project
If this is a new feature what is one way you can make this break?
It is not a breaking change, same behaviour as before