Skip to content

make some deployment functions virtual to make mocking easier in tests #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rootminus0x1 merged 1 commit into from
Feb 5, 2026
Merged

make some deployment functions virtual to make mocking easier in tests #30

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion script/src/contracts/Minter.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ abstract contract Minter is HarborFactoryDeployer {
address wrappedCollateral,
address peggedToken,
address leveragedToken
) internal returns (address proxy) {
) internal virtual returns (address proxy) {
string memory minterKey = string.concat(marketKey, "::minter");
console.log(" > %s", minterKey);

Expand Down
4 changes: 2 additions & 2 deletions script/src/contracts/StabilityPool.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ abstract contract StabilityPool is HarborFactoryDeployer {
address minter,
address wrappedCollateral,
StabilityPoolConfig memory config
) internal returns (address proxy) {
) internal virtual returns (address proxy) {
string memory spKey = string.concat(marketKey, "::stabilityPoolCollateral");
console.log(" > %s", spKey);

Expand Down Expand Up @@ -69,7 +69,7 @@ abstract contract StabilityPool is HarborFactoryDeployer {
address minter,
address leveragedToken,
StabilityPoolConfig memory config
) internal returns (address proxy) {
) internal virtual returns (address proxy) {
string memory spKey = string.concat(marketKey, "::stabilityPoolLeveraged");
console.log(" > %s", spKey);

Expand Down
2 changes: 1 addition & 1 deletion script/src/contracts/StabilityPoolManager.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ abstract contract StabilityPoolManager is HarborFactoryDeployer {
address treasury,
address stabilityPoolCollateral,
address stabilityPoolLeveraged
) internal returns (address proxy) {
) internal virtual returns (address proxy) {
string memory spmKey = string.concat(marketKey, "::stabilityPoolManager");
console.log(" > %s", spmKey);

Expand Down