Fix issue with Base64 encoding for basic auth#30
Open
airsource wants to merge 1 commit intobartdag:masterfrom
Open
Fix issue with Base64 encoding for basic auth#30airsource wants to merge 1 commit intobartdag:masterfrom
airsource wants to merge 1 commit intobartdag:masterfrom
Conversation
mehmetyazicioglu
approved these changes
Jul 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simple fix to resolve the newline encoded at the end of the basic auth string.
Symptom:
Cause:
As others have reported (e.g. here there's a problem with using the encode methods for Base64 encoding as they append a newline character, which results in an invalid header. This allegedly started to occur after a security fix made to Python.
Fix:
Replace the Base64 encode method with b64encode instead - this doesn't append a newline.