Open
Conversation
Updating fork
cleanup. bumped version
URLs matching the regular expression will be ignored
pylinkvalidator/models.py
Outdated
Owner
There was a problem hiding this comment.
slight optimization to prevent compiling the regex for every url:
self.excluded_urls = [re.compile(pattern) for pattern in self.options.excluded_urls.split(',')]
Owner
|
Thanks for the pull request, just a small thing to fix and if you could add a test, that would be great. To test, install nose (pip install nose) and run at the root of the project the following command: |
* refactor from pull request comments to compile regex * add exclude test
|
@jimpriest @bartdag Any updates on this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add ability to exclude a URL from being checked (regex) #7