feat(CHAIN-2551): modify MultisigScript for OPCM tasks #167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
✅ Heimdall Review Status
|
jackchuma
commented
Nov 11, 2025
script/universal/MultisigScript.sol
Outdated
| /// │ │ │ │ │ │ │ run() │ | ||
| /// │ │ │ │ │ │ │─────────────────────────────>│ | ||
| abstract contract MultisigScript is Script { | ||
| struct SafeTx { |
Contributor
Author
There was a problem hiding this comment.
Needed to add this to encapsulate inputs for one of the internal functions to avoid a stack too deep error
jjtny1
reviewed
Nov 11, 2025
script/universal/MultisigScript.sol
Outdated
| _executeTransaction({safe: safes[0], data: datas[0], value: value, signatures: signatures, broadcast: true}); | ||
| (bytes[] memory datas, uint256 value,) = _transactionDatas({safes: safes}); | ||
| (Vm.AccountAccess[] memory accesses, Simulation.Payload memory simPayload) = _executeTransaction({ | ||
| safe: safes[0], to: multicallAddress, data: datas[0], value: value, signatures: signatures, broadcast: true |
There was a problem hiding this comment.
Should this to: still be multicallAddress?
Contributor
Author
There was a problem hiding this comment.
I believe so, yes. Only the final execute call should be directed to OPCM. The approval flow still uses multicall
jjtny1
previously approved these changes
Nov 12, 2025
cb-heimdall
dismissed
jjtny1’s stale review
Approved review 3455536866 from jjtny1 is now dismissed due to new commit. Re-request for approval.
jjtny1
approved these changes
Nov 17, 2025
jackchuma
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifies
MultisigScriptto support DELEGATECALL operations to OPCM