Skip to content

Fix some issues linking erlang_js on recent FreeBSD (12.2). #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sobomax wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Fix some issues linking erlang_js on recent FreeBSD (12.2). #72

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7ecfc80
Correct linking of shared objects on FreeBSD.
sobomax Nov 18, 2021
6993f88
Make sure -lreadline can be found.
sobomax Nov 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion c_src/patches/js-src-config-FreeBSD.mk.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
+OS_CFLAGS = -DXP_UNIX -DSVR4 -DSYSV -D_BSD_SOURCE -DPOSIX_SOURCE -DHAVE_LOCALTIME_R
+
+RANLIB = echo
+MKSHLIB = $(LD) -shared $(XMKSHLIBOPTS)
+MKSHLIB = $(CC) -shared $(XMKSHLIBOPTS)
+
+#.c.o:
+# $(CC) -c -MD $*.d $(CFLAGS) $<
Expand Down
5 changes: 4 additions & 1 deletion rebar.config
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,10 @@

%% Prevent the make->gmake transition from infecting
%% MAKEFLAGS with bad flags that confuse gmake
{"freebsd.*", "MAKEFLAGS", ""}
{"freebsd.*", "MAKEFLAGS", ""},

%% Missing -lreadline
{"freebsd.*", "LDFLAGS", "-L/usr/local/lib"}

]}.

Expand Down