Add regression test for separate_turn_on_commands race condition#1379
Open
basnijholt wants to merge 1 commit intomainfrom
Open
Add regression test for separate_turn_on_commands race condition#1379basnijholt wants to merge 1 commit intomainfrom
basnijholt wants to merge 1 commit intomainfrom
Conversation
Regression test for #1373 This test verifies that when `separate_turn_on_commands: true` is enabled and a light is turned off between split commands, the second command should be skipped. The bug occurs because the proactive adaptation context is never cleared when `light.turn_off` is called, causing the off-check to be bypassed in `_execute_adaptation_calls`. This test currently FAILS (demonstrating the bug) and will PASS after the fix is implemented.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bug Description
When
separate_turn_on_commands: trueis enabled and a light is turned off between the split brightness and color commands, the second command should be skipped. Currently it's not because:light.turn_offis called_execute_adaptation_calls(switch.py:1337-1349) to be bypassedTest plan
Related
Closes #1373 (after fix is implemented)