Skip to content

Adding event when the user accepts camera permissions#75

Open
ivangarcia2 wants to merge 1 commit intobasst314:masterfrom
ivangarcia2:initSuccess
Open

Adding event when the user accepts camera permissions#75
ivangarcia2 wants to merge 1 commit intobasst314:masterfrom
ivangarcia2:initSuccess

Conversation

@ivangarcia2
Copy link

I added an event when the user accept camera persmissions. This event will be true if there are cameras in the system or false if there are not.

I believe this is interesting to better control user interface messages.

@basst314
Copy link
Owner

basst314 commented Dec 2, 2021

Hi @ivangarcia2,
thanks for participating in this project! Looking at the diff, it seems like the new event emitter is triggered the same way as the existing cameraSwitched one - whenever a new camera stream is activated. This could be either initially when a user gave permissions, or when a user switched between cameras.
It looks like the new event emitter is redundant, in which case I'd rather stick to the exiting one.
Please let me know if I missed anything. Thanks!

For future reference, please keep file changes minimal and avoid reformatting existing code, this makes the diff harder to read.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants