Include user link flags in device links#416
Open
JamesMBartlett wants to merge 1 commit intobazel-contrib:mainfrom
Open
Include user link flags in device links#416JamesMBartlett wants to merge 1 commit intobazel-contrib:mainfrom
JamesMBartlett wants to merge 1 commit intobazel-contrib:mainfrom
Conversation
Signed-off-by: James Bartlett <james@gimletlabs.ai>
JamesMBartlett
requested review from
cloudhan,
jsharpe and
ryanleary
as code owners
Collaborator
|
Sorry for the delay. Would you mind porting it to nvcc_msvc and clang config? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was seeing undefined reference errors when trying to device link a cuda file with NVSHMEM, eg.:
This PR adds user link flags to the device link command line, so that eg.
-lnvshmemcan be passed down to the device linking, and it fixes the error I encountered above.