Register apple_xplat_toolchain and use exec_groups everywhere #2854
Conversation
adincebic
requested review from
aaronsky,
brentleyjones,
keith,
luispadron and
mattrobmattrob
as code owners
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
adincebic
force-pushed
the
adin/toolchains
branch
2 times, most recently
from
200f745 to
c699c7a
Compare
| # The name of the execution group used to run j2objc linking actions. | ||
| _J2OBJC_LINKING_EXEC_GROUP = "j2objc" |
There was a problem hiding this comment.
j2objc is otherwise removed from the open source rules. not keen on reintroducing a remnant of it here
There was a problem hiding this comment.
Yeah, let's drop all j2objc additions in any cherry-picks.
PiperOrigin-RevId: 555946371 (cherry picked from commit ab042c5)
adincebic
force-pushed
the
adin/toolchains
branch
from
fed82e4 to
41bbf19
Compare
| toolchains = swift_common.use_toolchain() + use_cpp_toolchain(), | ||
| exec_groups = dicts.add( | ||
| { | ||
| _SWIFT_EXEC_GROUP: exec_group( |
There was a problem hiding this comment.
Just to check, I know this is eventually removed. Did we already remove that from later commits?
There was a problem hiding this comment.
I have to check that too.
| # The name of the execution group used to run j2objc linking actions. | ||
| _J2OBJC_LINKING_EXEC_GROUP = "j2objc" |
There was a problem hiding this comment.
Yeah, let's drop all j2objc additions in any cherry-picks.
(cherry picked from commit ab042c551da67f523e69cdf5d49feaa4ec108953)