Add the serial field to NetBox VirtualMachine
#435
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e 'instanceUuid' Signed-off-by: Joachim Burket <joachim.burket@protonmail.ch>
Contributor
Author
|
Hi @bb-Ricardo, I've tested this locally and it seems to work. |
joachimBurket
changed the title
serial field to NetBox VirtualMachine
Owner
|
Hey, thank you for this quick PR. We need to make it backwards compatible to not break integration with pre 4.1 NetBox installations. |
Signed-off-by: joachimBurket <joachim.burket@protonmail.ch>
Contributor
Author
|
Oh good call! I pushed a new commit to only add the |
Contributor
Author
|
@bb-Ricardo does it seems good to you? |
Owner
|
Hi, Yes, this looks like a sufficient solution. Unfortunately I'm unable to work on this right now. Will merge your PR as soon as I got some time tontake care of some issue. Thank you very much again. |
Contributor
Author
|
Okay, no worry! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #434
Add the
serialfield to NetBox VirtualMachine and set it from VMWareinstanceUuid