Multiple platforms setup #5
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
sys.platformto determine the platform is more professional and more common in Python setup than usingplatform.system(). For more details: When to use os.name, sys.platform, or platform.system?NameError: name 'package_data' is not defined, which is quite confusing.)Things that I don't know how to fix:
python setup.py installon both Linux and Cygwin. And I can see the installation works (I will show the result on cygwin, which is similar to the result on Linux):But when I import the sbol from python, I got:
I guess the libsbol is not installed correctly. Hope you can work it out. Otherwise just remove the
linux2andcygwinsupport in setup.py.