31830 - Validate Optional Phone Number in ContactInfo if Provided#298
Merged
severinbeauvais merged 2 commits intobcgov:mainfrom Jan 22, 2026
Conversation
severinbeauvais
approved these changes
Jan 21, 2026
Collaborator
There was a problem hiding this comment.
Looks fine.
Are there any unit tests that need to be added or could be updated?
Can you try to regenerate the Storybook files, please?
Ref: https://github.com/bcgov/bcrs-shared-components?tab=readme-ov-file#10-build-storybook-and-verify-your-component
Collaborator
Author
|
Also updated the error message as per Jacqueline's request.
|
severinbeauvais
approved these changes
Jan 22, 2026
Collaborator
severinbeauvais
left a comment
severinbeauvais
left a comment
There was a problem hiding this comment.
Approved. Stand by while I merge and then publish this change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #: /bcgov/entity#31830
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-filings-ui license (Apache 2.0).