Fix CI linting for Namex Solr Importer#29
Merged
stevenc987 merged 11 commits intobcgov:mainfrom Feb 4, 2026
Merged
Conversation
Signed-off-by: Chen <Steven.Chen@gov.bc.ca>
Signed-off-by: Chen <Steven.Chen@gov.bc.ca>
Signed-off-by: Chen <Steven.Chen@gov.bc.ca>
Signed-off-by: Chen <Steven.Chen@gov.bc.ca>
Signed-off-by: Chen <Steven.Chen@gov.bc.ca>
Signed-off-by: Chen <Steven.Chen@gov.bc.ca>
Signed-off-by: Chen <Steven.Chen@gov.bc.ca>
Signed-off-by: Chen <Steven.Chen@gov.bc.ca>
Signed-off-by: Chen <Steven.Chen@gov.bc.ca>
ozamani9gh
reviewed
Feb 4, 2026
Collaborator
ozamani9gh
left a comment
ozamani9gh
left a comment
There was a problem hiding this comment.
have a look at my two comments, if you are happy with what you have done i can approve this PR
| return cx_Oracle.SessionPool( | ||
| user=current_app.config.get("ORACLE_USER"), | ||
| password=current_app.config.get("ORACLE_PASSWORD"), | ||
| dsn=dsn, |
Collaborator
There was a problem hiding this comment.
dsn=dsn is hard to read should we rename variable something beside dsn.
| # POSSIBILITY OF SUCH DAMAGE. | ||
| """Test Suite to ensure reindexing works as expected.""" | ||
|
|
||
| def test_data_import_handler(app): |
Collaborator
There was a problem hiding this comment.
what does app do... do we need to still pass it to the TEST
Collaborator
Author
There was a problem hiding this comment.
- I have changed the name of dns
- This app was not used in the test codes so it got complaint by commands in the CI. That was why I removed it.
Signed-off-by: Chen <Steven.Chen@gov.bc.ca>
Signed-off-by: Chen <Steven.Chen@gov.bc.ca>
mengdong19
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
*Issue:*https://github.com/bcgov/entity/issues/#31712
Description of changes:
Fixed Linter configs in the CI for https://github.com/bcgov/namex-search/tree/main/namex-solr-importer are broken.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namex license (Apache 2.0).