Fix CI-namex-bad-name-notifier and sftp-nuans-report#1962
Merged
stevenc987 merged 3 commits intobcgov:mainfrom Feb 26, 2026
Merged
Fix CI-namex-bad-name-notifier and sftp-nuans-report#1962stevenc987 merged 3 commits intobcgov:mainfrom
stevenc987 merged 3 commits intobcgov:mainfrom
Conversation
stevenc987
requested review from
davemck513,
hfekete,
mengdong19,
ozamani9gh and
rarmitag
as code owners
hfekete
reviewed
Feb 24, 2026
Signed-off-by: Chen <Steven.Chen@gov.bc.ca> 32238-Fix CI-namex-bad-name-notifier Signed-off-by: Chen <Steven.Chen@gov.bc.ca> 32240-Fix CI and lint - sftp-nuans-report Signed-off-by: Chen <Steven.Chen@gov.bc.ca> 32238-Fix CI - namex-bad-name-notifier Signed-off-by: Chen <Steven.Chen@gov.bc.ca> 32238-Fix CI - namex-bad-name-notifier Signed-off-by: Chen <Steven.Chen@gov.bc.ca> 32238-Fix CI - namex-bad-name-notifier Signed-off-by: Chen <Steven.Chen@gov.bc.ca> 32238-Fix CI - namex-bad-name-notifier Signed-off-by: Chen <Steven.Chen@gov.bc.ca> 32238-Fix CI - namex-bad-name-notifier Signed-off-by: Chen <Steven.Chen@gov.bc.ca> 32238-Fix CI - namex-bad-name-notifier Signed-off-by: Chen <Steven.Chen@gov.bc.ca> 32238-Fix CI - namex-bad-name-notifier Signed-off-by: Chen <Steven.Chen@gov.bc.ca> 32238-Fix CI - namex-bad-name-notifier Signed-off-by: Chen <Steven.Chen@gov.bc.ca> 32238-Fix CI - namex-bad-name-notifier Signed-off-by: Chen <Steven.Chen@gov.bc.ca> 32238-Fix CI - namex-bad-name-notifier and sftp_nuans_report
hfekete
approved these changes
Feb 26, 2026
Collaborator
hfekete
left a comment
hfekete
left a comment
There was a problem hiding this comment.
Looks good, there are few minor comments it would not be bad to act on but are not major show stoppers.
| def get_yesterday_utc_range(): | ||
| pacific = pytz.timezone('America/Los_Angeles') | ||
| """Calculate the start of today and yesterday in Pacific Time""" | ||
| pacific = pytz.timezone("America/Los_Angeles") |
Collaborator
There was a problem hiding this comment.
why US LA timezone ? can you use "Canada/Pacific" ?
Collaborator
Author
There was a problem hiding this comment.
Change it to America/Vancouver as agreed.
| assert engine is not None | ||
|
|
||
|
|
||
| # def test_sftp_connection_succeed(): # pylint:disable=unused-argument |
Collaborator
There was a problem hiding this comment.
we can remove unused code
|
|
||
|
|
||
| def test_sqlalchemy_uri_without_instance(monkeypatch): | ||
| monkeypatch.delenv("DATABASE_INSTANCE_CONNECTION_NAME", raising=False) |
Collaborator
There was a problem hiding this comment.
I havent seen anywhere, but I hope we are not using same DB urls for tests and for the real app :)
Signed-off-by: Chen <Steven.Chen@gov.bc.ca>
Signed-off-by: Chen <Steven.Chen@gov.bc.ca>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Fix CI for bad-name-notifier
Added test case
Fix CI for sftp-nuans-report
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namex license (Apache 2.0).