feat: 2147 Update notification message to use Carbon notification component#2382
Open
xiaopeng0202 wants to merge 5 commits intomainfrom
Open
feat: 2147 Update notification message to use Carbon notification component#2382xiaopeng0202 wants to merge 5 commits intomainfrom
xiaopeng0202 wants to merge 5 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the moisture content and purity test screens to use Carbon’s InlineNotification component instead of Material UI Alert, aligning notifications with the app’s Carbon design system usage.
Changes:
- Replaced MUI
Alertwith CarbonInlineNotificationin MoistureContent and PurityContent screens. - Added/updated SCSS for notification positioning and styling in both views.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| frontend/src/views/CONSEP/TestingActivities/PurityContent/styles.scss | Adds styling for the new Carbon notification on the purity screen. |
| frontend/src/views/CONSEP/TestingActivities/PurityContent/index.tsx | Switches purity screen notification rendering from MUI Alert to Carbon InlineNotification. |
| frontend/src/views/CONSEP/TestingActivities/MoistureContent/styles.scss | Adjusts notification positioning/layout for the moisture screen. |
| frontend/src/views/CONSEP/TestingActivities/MoistureContent/index.tsx | Switches moisture screen notification rendering from MUI Alert to Carbon InlineNotification. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
frontend/src/views/CONSEP/TestingActivities/PurityContent/styles.scss
Outdated
Show resolved
Hide resolved
frontend/src/views/CONSEP/TestingActivities/MoistureContent/styles.scss
Outdated
Show resolved
Hide resolved
| {alert?.message | ||
| && (<Alert className="consep-moisture-content-alert" severity={alert?.isSuccess ? 'success' : 'error'}>{alert?.message}</Alert>)} | ||
| && ( | ||
| <InlineNotification |
Collaborator
Collaborator
Collaborator
|
Could you share some screenshots of the success and error notification after the change? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



…ponent
Description
Closes #2147
Changelog
Changed
How was this tested?
What gif/image best describes this PR or how it makes you feel?
Thanks for the PR!
Deployments, as required, will be available below:
Please create PRs in draft mode. Mark as ready to enable:
After merge, new images are deployed in: