This repository was archived by the owner on May 24, 2022. It is now read-only.
Financing Statement select and change type.#871
Open
bryan-gilbert wants to merge 3 commits intobcgov:masterfrom
Open
Financing Statement select and change type.#871bryan-gilbert wants to merge 3 commits intobcgov:masterfrom
bryan-gilbert wants to merge 3 commits intobcgov:masterfrom
Conversation
added 2 commits
March 26, 2020 12:58
wip Adjust unit test
Codecov Report
@@ Coverage Diff @@
## master #871 +/- ##
==========================================
- Coverage 93.78% 93.19% -0.59%
==========================================
Files 59 61 +2
Lines 1352 1382 +30
Branches 118 119 +1
==========================================
+ Hits 1268 1288 +20
- Misses 82 92 +10
Partials 2 2
Continue to review full report at Codecov.
|
|
Kudos, SonarCloud Quality Gate passed!
|
jguertin
approved these changes
Mar 26, 2020
Contributor
jguertin
left a comment
jguertin
left a comment
There was a problem hiding this comment.
I certainly wouldn't mind if the coverage checks stopped wining when coverage drops, but I still like general reporting of coverage, in particular on master.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a confirmation dialog component.
When Repairer's Lien elements are added will need to toggle their display based on selected type.
May wish to only show the confirm change dialog after user has actually made a change.