32591 enable Transfer to Surviving Joint Tenant without new FF#2300
32591 enable Transfer to Surviving Joint Tenant without new FF#2300eve-git merged 2 commits intobcgov:mainfrom
Conversation
|
/gcbrun |
There was a problem hiding this comment.
Pull request overview
Enables “Transfer to Surviving Joint Tenant(s)” for Qualified Suppliers (lawyers/notaries) without requiring a new feature flag, while keeping the existing feature flag to gate the broader “Transfer Due to Death” options.
Changes:
- Add a QS fallback list that includes only the first “Transfer Due to Death” option when the TOD feature flag is disabled.
- Update QS transfer type selection logic to use the fallback list when the TOD feature flag is off.
- Bump
ppr-uipackage version from6.0.8to6.0.9.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
ppr-ui/src/resources/transferTypes.ts |
Adjusts QS transfer-type options to allow surviving joint tenant transfer without enabling full TOD list. |
ppr-ui/package.json |
Increments UI package version. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
| } | ||
| ] | ||
|
|
||
| const toDTypesForLawyersAndQSNotary: Array<TransferTypeSelectIF> = (() => { |
There was a problem hiding this comment.
We could probably improve the capitalization and name a bit here:
todTypesForQsLawyersAndNotaries or something along those lines.
| const survivingJointTenant = transferDueToDeathTypes.find( | ||
| type => type.transferType === ApiTransferTypes.SURVIVING_JOINT_TENANT | ||
| ) | ||
| return survivingJointTenant ? [header, survivingJointTenant] : [header] |
There was a problem hiding this comment.
I don't believe you need to the return ternary here.
ie return [header, survivingJointTenant]
cameron-eyds
left a comment
cameron-eyds
left a comment
There was a problem hiding this comment.
Just a few small comments
Issue #: /bcgov/entity###
bcgov/entity#32591
Description of changes:
enable Transfer to Surviving Joint Tenant without new FF
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the PPR license (Apache 2.0).