chore(ci): fix Trivy scanner param and runner#572
Closed
DerekRoberts wants to merge 1 commit intomainfrom
Closed
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the CI security analysis workflow to correct Trivy scanner configuration and adjust the GitHub Actions runner selection to address Trivy execution/download issues.
Changes:
- Update Trivy
scannersvalue fromconfigtomisconfig. - Change the job runner from
ubuntu-24.04toubuntu-latest.
| name: Trivy Security Scan | ||
| if: github.event_name != 'pull_request' || !github.event.pull_request.draft | ||
| runs-on: ubuntu-24.04 | ||
| runs-on: ubuntu-latest |
There was a problem hiding this comment.
Using ubuntu-latest makes the workflow non-deterministic because the underlying Ubuntu version changes over time and may already resolve to 24.04, which would not address the reported Trivy download issue. If the goal is to avoid 24.04, consider pinning to a known-good runner image (e.g., ubuntu-22.04) and keep runner versions consistent with other workflows in this repo that are explicitly pinned (e.g., .github/workflows/merge.yml, .github/workflows/.tests.yml).
Suggested change
| runs-on: ubuntu-latest | |
| runs-on: ubuntu-22.04 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
scannersfromvuln,secret,configtovuln,secret,misconfig(correct scanner name)\n- Change runner fromubuntu-24.04toubuntu-latestto fix Trivy binary download failuresThanks for the PR!
Any successful deployments (not always required) will be available below.
API available
Frontend available
Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow